From f2ca87d6aa4385b191ae40f677dd74272e139e7e Mon Sep 17 00:00:00 2001 From: amirghasempoor Date: Tue, 25 Feb 2025 16:30:05 +0330 Subject: [PATCH] remove the redundant relation --- .../V3/Dashboard/RoadObservationController.php | 13 +++++++------ 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/app/Http/Controllers/V3/Dashboard/RoadObservationController.php b/app/Http/Controllers/V3/Dashboard/RoadObservationController.php index 1182a8fb..ff534f53 100644 --- a/app/Http/Controllers/V3/Dashboard/RoadObservationController.php +++ b/app/Http/Controllers/V3/Dashboard/RoadObservationController.php @@ -22,9 +22,6 @@ use Hekmatinasser\Verta\Verta; use Illuminate\Http\JsonResponse; use Illuminate\Http\Request; use App\Services\Cartables\RoadObservationTableService; -use Illuminate\Support\Facades\Auth; -use Illuminate\Support\Facades\Storage; -use Illuminate\Support\Str; use Maatwebsite\Excel\Facades\Excel; use SoapFault; use Symfony\Component\HttpFoundation\BinaryFileResponse; @@ -151,7 +148,8 @@ class RoadObservationController extends Controller public function refer(ReferRequest $request, RoadObserved $roadObserved): JsonResponse { - $roadObserved->problemHistories()->create([ + RoadObservationHistory::query()->create([ + 'id' => $roadObserved->id, 'user_id' => auth()->user()->id, 'action' => 'refer', 'description' => $request->refer_description, @@ -174,7 +172,9 @@ class RoadObservationController extends Controller public function referList(RoadObserved $roadObserved): JsonResponse { $referList = []; - $data = $roadObserved->problemHistories()->where('action', '=', 'refer')->get(); + $data = RoadObservationHistory::query() + ->where('road_observation_histories.id', $roadObserved->id) + ->where('action', '=', 'refer')->get(); foreach ($data as $key => $value) { $referList[$key]['from_edareh'] = EdarateShahri::query()->find($value->from_edareh)->name_fa; @@ -209,7 +209,8 @@ class RoadObservationController extends Controller 'status_fa' => null, ]); - $roadObserved->problemHistories()->create([ + RoadObservationHistory::query()->create([ + 'id' => $roadObserved->id, 'user_id' => auth()->user()->id, 'action' => 'restore', 'description' => $request->restore_description,