improve code in controller and form request for V3 whit pint package
This commit is contained in:
@@ -16,6 +16,7 @@ use Illuminate\Validation\ValidationException;
|
||||
class ObservedItemController extends Controller
|
||||
{
|
||||
use ApiResponse;
|
||||
|
||||
public function show(ObservedItem $observedItem): JsonResponse
|
||||
{
|
||||
return $this->successResponse($observedItem);
|
||||
@@ -23,9 +24,9 @@ class ObservedItemController extends Controller
|
||||
|
||||
public function filter(Request $request): JsonResponse
|
||||
{
|
||||
$columns = array(
|
||||
$columns = [
|
||||
'id', 'item_id', 'road_patrol_id', 'roadPatrol.start_time', 'roadPatrol.end_time',
|
||||
);
|
||||
];
|
||||
|
||||
$allowedFilters = $columns;
|
||||
$allowedSortings = $columns;
|
||||
@@ -76,7 +77,7 @@ class ObservedItemController extends Controller
|
||||
$item_end_coordinates = null;
|
||||
|
||||
if ($info_item->needs_end_point) {
|
||||
if (!isset($item['end_point'])) {
|
||||
if (! isset($item['end_point'])) {
|
||||
throw ValidationException::withMessages([
|
||||
"observed_items.$index.end_point" => __('validation.required', ['attribute' => 'end_point']),
|
||||
]);
|
||||
|
||||
Reference in New Issue
Block a user