From 3a18048ceed8f1857309c3557b2130f06f25e424 Mon Sep 17 00:00:00 2001
From: faezehzafarbakhsh <faezehzafarbakhsh@gmail.com>
Date: Sat, 25 Oct 2025 15:04:18 +0330
Subject: [PATCH] fix and improve the code

---
 .../V3/Dashboard/RoleManagementController.php |  4 +--
 .../Dashboard/RoleManageMent/StoreRequest.php |  1 -
 .../RoleManageMent/UpdateRequest.php          |  1 -
 app/Services/Cartables/Role/RoleService.php   | 25 -------------------
 4 files changed, 1 insertion(+), 30 deletions(-)
 delete mode 100644 app/Services/Cartables/Role/RoleService.php

diff --git a/app/Http/Controllers/V3/Dashboard/RoleManagementController.php b/app/Http/Controllers/V3/Dashboard/RoleManagementController.php
index 1461bb54..ccc3caac 100644
--- a/app/Http/Controllers/V3/Dashboard/RoleManagementController.php
+++ b/app/Http/Controllers/V3/Dashboard/RoleManagementController.php
@@ -26,7 +26,7 @@ class RoleManagementController extends Controller
             $request,
             allowedFilters: ['*'],
             allowedSortings: ['*'],
-            allowedSelects: ['id', 'name', 'name_fa', 'description', 'for_report']
+            allowedSelects: ['id', 'name', 'name_fa', 'description']
     );
         return response()->json($data);
     }
@@ -45,7 +45,6 @@ class RoleManagementController extends Controller
                 'name_fa' => $request->name_fa,
                 'description' => $request->description,
                 'guard_name' => 'web',
-                'for_report' => $request->for_report,
             ]);
 
             $role->givePermissionTo($request->permissions);
@@ -68,7 +67,6 @@ class RoleManagementController extends Controller
                 'name_fa' => $request->name_fa,
                 'description' => $request->description,
                 'guard_name' => 'web',
-                'for_report' => $request->for_report,
             ]);
 
             $role->syncPermissions($request->permissions);
diff --git a/app/Http/Requests/V3/Dashboard/RoleManageMent/StoreRequest.php b/app/Http/Requests/V3/Dashboard/RoleManageMent/StoreRequest.php
index 27e725b6..4f628943 100644
--- a/app/Http/Requests/V3/Dashboard/RoleManageMent/StoreRequest.php
+++ b/app/Http/Requests/V3/Dashboard/RoleManageMent/StoreRequest.php
@@ -26,7 +26,6 @@ class StoreRequest extends FormRequest
             'name' => 'required|string|unique:roles,name',
             'name_fa' => 'required|string',
             'description' =>'string',
-            'for_report' => 'in:0,1',
             'permissions' => 'array',
             'permissions.*' => 'integer|exists:permissions,id'
         ];
diff --git a/app/Http/Requests/V3/Dashboard/RoleManageMent/UpdateRequest.php b/app/Http/Requests/V3/Dashboard/RoleManageMent/UpdateRequest.php
index 615b3ff6..c2ced356 100644
--- a/app/Http/Requests/V3/Dashboard/RoleManageMent/UpdateRequest.php
+++ b/app/Http/Requests/V3/Dashboard/RoleManageMent/UpdateRequest.php
@@ -27,7 +27,6 @@ class UpdateRequest extends FormRequest
             'name' => ['required', 'string', 'max:255',Rule::unique('roles','name')->ignore($this->role->id)],
             'name_fa' => 'required|string',
             'description' =>'string',
-            'for_report' => 'in:0,1',
             'permissions' => 'array',
             'permissions.*' => 'integer|exists:permissions,id'
         ];
diff --git a/app/Services/Cartables/Role/RoleService.php b/app/Services/Cartables/Role/RoleService.php
deleted file mode 100644
index c43adb95..00000000
--- a/app/Services/Cartables/Role/RoleService.php
+++ /dev/null
@@ -1,25 +0,0 @@
-<?php
-
-namespace App\Services\Cartables\Role;
-
-use App\Exceptions\ProhibitedAction;
-use App\Facades\DataTable\DataTableFacade;
-use App\Models\Damage;
-use App\Models\Role;
-use App\Models\SafetyAndPrivacy;
-use Illuminate\Http\Request;
-use Illuminate\Support\Facades\DB;
-
-class RoleService
-{
-    public function dataTable(Request $request): array
-    {
-        return DataTableFacade::run(
-            Role::query(),
-            $request,
-            allowedFilters: ['*'],
-            allowedSortings: ['*'],
-            allowedSelects: ['id', 'name', 'name_fa', 'guard_name', 'description', 'for_report']
-        );
-    }
-}